Maintain categorical clavrx data as integer arrays #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 12, 2021 09:53
Keep old behavior for non-integer data
Codecov Report
@@ Coverage Diff @@
## main #1792 +/- ##
==========================================
- Coverage 92.90% 92.90% -0.01%
==========================================
Files 265 265
Lines 38970 38979 +9
==========================================
+ Hits 36205 36213 +8
- Misses 2765 2766 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
djhoese
approved these changes
Aug 16, 2021
|
No. |
simonrp84
pushed a commit
to simonrp84/satpy
that referenced
this pull request
Nov 24, 2021
* Fix categorical data by making sure fill_value is applied as an integer. Keep old behavior for non-integer data * Test that int data remains integer after loading. * Add some type checking and check there is a _FillValue for int but not float Co-authored-by: Joleen Feltz <joleenf@ssec.wisc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug that turns categorical data into float arrays after the valid_range is applied. This is done by using the fill value to fill the data outside of the valid_range for integer. This PR also adds tests to make verify that int arrays have _FillValue and remain integer, while float arrays have no _FillValue in the output attributes and remain float.