Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new composite (true_color_with_night_fires) to GOES/ABI: True color (day) with fires (night) #1769

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

simonrp84
Copy link
Member

Last week I made a new composite for GOES/ABI that combines the true_color images for daytime with cira_fire_temperature at night.
Several people have since been in touch asking me how I made images using this composite, so I thought it worth adding to satpy main. This is only YAML changes and shouldn't affect any code / tests.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #1769 (268d187) into main (fc66d32) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files         285      285           
  Lines       43754    43754           
=======================================
  Hits        41108    41108           
  Misses       2646     2646           
Flag Coverage Δ
behaviourtests 4.73% <ø> (ø)
unittests 94.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Jul 19, 2021

Coverage Status

Coverage remained the same at 94.571% when pulling 268d187 on simonrp84:abi_truecol_fires into fc66d32 on pytroll:main.

@gerritholl
Copy link
Member

@simonrp84 Any updates on this?

@simonrp84
Copy link
Member Author

Had forgotten about it, to be honest. I have no idea what the limits of the crude stretch should be! Will try with @pnuu's suggestion and see how it looks.

@simonrp84
Copy link
Member Author

@pnuu and @mraspaud were correct, the enhancement should be crude. Have updated and this should be ready to merge now.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese added enhancement code enhancements, features, improvements component:compositors labels Aug 2, 2022
@djhoese djhoese changed the title Add new composite to GOES/ABI: True color (day) with fires (night). Add new composite (true_color_with_night_fires) to GOES/ABI: True color (day) with fires (night) Aug 2, 2022
@djhoese djhoese merged commit b62e028 into pytroll:main Aug 3, 2022
@simonrp84 simonrp84 deleted the abi_truecol_fires branch August 3, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants