Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VIRR reader handling valid_range when it is a numpy array #1744

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

joleenf
Copy link
Contributor

@joleenf joleenf commented Jun 29, 2021

The valid_range can be an ndarray when it is read, making the boolean if valid_range: the incorrect choice for the data type. Since valid_range can either be an ndarray or None, convert the ndarray to a list so that later boolean checks don't fail.

@joleenf joleenf requested review from djhoese and mraspaud as code owners June 29, 2021 14:46
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1744 (32c4e02) into main (b2af59a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   92.83%   92.83%   -0.01%     
==========================================
  Files         260      260              
  Lines       38556    38558       +2     
==========================================
+ Hits        35793    35794       +1     
- Misses       2763     2764       +1     
Flag Coverage Δ
behaviourtests 4.81% <0.00%> (-0.01%) ⬇️
unittests 93.37% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/virr_l1b.py 94.59% <50.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2af59a...32c4e02. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 93.319% when pulling 32c4e02 on joleenf:virr_l1b into b2af59a on pytroll:main.

@djhoese djhoese changed the title BUG FIX: need to check if valid_range is an ndarray Fix VIRR reader handling valid_range when it is a numpy array Jun 29, 2021
@djhoese djhoese merged commit f736315 into pytroll:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants