Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when calling to_xarray_dataset on an empty scene #1698

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Fix error when calling to_xarray_dataset on an empty scene #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f04c7d
fix: empty scene to_xarray_dataset
BENR0 May 28, 2021
23168a6
test: add test for empty scene to xarray dataset
BENR0 Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions satpy/scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,9 @@ def to_xarray_dataset(self, datasets=None):
"""
dataarrays = self._get_dataarrays_from_identifiers(datasets)

if len(dataarrays) == 0:
return xr.Dataset()

ds_dict = {i.attrs['name']: i.rename(i.attrs['name']) for i in dataarrays if i.attrs.get('area') is not None}
mdata = combine_metadata(*tuple(i.attrs for i in dataarrays))
if mdata.get('area') is None or not isinstance(mdata['area'], SwathDefinition):
Expand Down
10 changes: 10 additions & 0 deletions satpy/tests/test_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,6 +1745,16 @@ def test_save_dataset_default(self):
class TestSceneConversions(unittest.TestCase):
"""Test Scene conversion to geoviews, xarray, etc."""

def test_to_xarray_dataset_with_empty_scene(self):
"""Test converting empty Scene to xarray dataset."""
from satpy import Scene
from xarray import Dataset
scn = Scene()
xrds = scn.to_xarray_dataset()
assert isinstance(xrds, Dataset)
assert len(xrds.variables) == 0
assert len(xrds.coords) == 0

def test_geoviews_basic_with_area(self):
"""Test converting a Scene to geoviews with an AreaDefinition."""
from satpy import Scene
Expand Down