-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when calling to_xarray_dataset on an empty scene #1698
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
+ Coverage 92.32% 92.42% +0.10%
==========================================
Files 258 258
Lines 38125 37625 -500
==========================================
- Hits 35200 34776 -424
+ Misses 2925 2849 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This needs a unit test. It should be quite easy to write a unit test for this case. |
@BENR0 Can you add a small test for this? |
@djhoese Added a test for the empty Scene. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If
to_xarray_dataset
is called on an empty Scene instead of an error an empty xarray dataset is now returned.