-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reference to sector_id global key in 'awips_tiled' writer YAML #1691
Conversation
… matches the code.
Do you think you could add a check for the sector_id in one of the tests, maybe this one:
and make sure that it fails without your change and passes with it? |
Codecov Report
@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 258 258
Lines 38123 38125 +2
=======================================
+ Hits 35196 35200 +4
+ Misses 2927 2925 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Change raw_value to value for default_clavrx physical_element since it is a variable rather than fix value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
This edits one line in awips_tiled.py so that the key "add_sector_id_global" is used for applying the sector_id to the global attributes. This key is chosen since it matches the key defined in the awips_tiled.yaml file
satpy/satpy/etc/writers/awips_tiled.yaml
Line 58 in 88938ab