Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to sector_id global key in 'awips_tiled' writer YAML #1691

Merged
merged 3 commits into from
May 26, 2021

Conversation

joleenf
Copy link
Contributor

@joleenf joleenf commented May 26, 2021

This edits one line in awips_tiled.py so that the key "add_sector_id_global" is used for applying the sector_id to the global attributes. This key is chosen since it matches the key defined in the awips_tiled.yaml file

add_sector_id_global: true

@joleenf joleenf requested a review from djhoese as a code owner May 26, 2021 16:07
@djhoese
Copy link
Member

djhoese commented May 26, 2021

Do you think you could add a check for the sector_id in one of the tests, maybe this one:

def test_basic_numbered_tiles(self, tile_count, tile_size):

and make sure that it fails without your change and passes with it?

@djhoese djhoese self-assigned this May 26, 2021
@djhoese djhoese changed the title fix reference to sector_id global key Fix reference to sector_id global key in 'awips_tiled' writer YAML May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #1691 (d8522ae) into main (88938ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         258      258           
  Lines       38123    38125    +2     
=======================================
+ Hits        35196    35200    +4     
+ Misses       2927     2925    -2     
Flag Coverage Δ
behaviourtests 4.84% <0.00%> (-0.01%) ⬇️
unittests 92.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_awips_tiled.py 98.23% <100.00%> (+<0.01%) ⬆️
satpy/writers/awips_tiled.py 82.55% <100.00%> (+0.22%) ⬆️
satpy/tests/test_composites.py 99.88% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88938ab...d8522ae. Read the comment docs.

@coveralls
Copy link

coveralls commented May 26, 2021

Coverage Status

Coverage increased (+0.006%) to 92.818% when pulling d8522ae on joleenf:awips_sectorid_key into 88938ab on pytroll:main.

Change raw_value to value for default_clavrx physical_element since
it is a variable rather than fix value.
@joleenf joleenf requested a review from mraspaud as a code owner May 26, 2021 16:43
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@djhoese djhoese merged commit 25993ff into pytroll:main May 26, 2021
@joleenf joleenf deleted the awips_sectorid_key branch May 26, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants