Apply valid_range in MiRS reader when present #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of https://github.com/pytroll/satpy
Remove platform name from parameterize in last test for kwargs because they are not used in that test. Add a test for the NOAA-20 platform when the limb_correction assertions are tested and platform name is tested.
Merge remote-tracking branch 'upstream/master'
Fixes a bug in which valid range was ignored.
Codecov Report
@@ Coverage Diff @@
## master #1655 +/- ##
==========================================
+ Coverage 92.61% 92.65% +0.03%
==========================================
Files 258 258
Lines 37783 37948 +165
==========================================
+ Hits 34994 35161 +167
+ Misses 2789 2787 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
djhoese
reviewed
Apr 30, 2021
satpy/readers/mirs.py
Outdated
| @@ -356,6 +356,17 @@ def _fill_data(self, data_arr, attrs): | |||
| data_arr = data_arr.where(data_arr != fill_value, fill_out) | |||
| return data_arr, attrs | |||
|
|
|||
| def _get_valid_range(self, data_arr, attrs): | |||
There was a problem hiding this comment.
Suggested change
| def _get_valid_range(self, data_arr, attrs): | |
| def _apply_valid_range(self, data_arr, attrs): |
Really nitpicking here. Not necessary unless you make other changes.
Change get_valid_range=>apply_valid_range and check for case of valid_range not None
only read fake_data one time, not every time check_valid_range is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which the valid range was not used. Fix checks for a valid range in the attributes and applies the range if present. There is a new check in the test code which determines if valid_range is removed from the attributes after loading the data.