Fix combine_metadata not handling lists of different sizes #1643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
combine_metadata
utility function doesn't seem to handle lists of different sizes. Before this PR you'd get something like this:This PR fixes this by catching this ValueError when trying to compare lists. I wanted to have a simple additional check like
if len(x) != len(y): return False
, but the function that is triggering this issue is meant to compare any value including those that may not have alen
parameter.