Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add altitude in the list of dataset for OLCI.nc #1555

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

ghislainp
Copy link
Contributor

@ghislainp ghislainp commented Feb 19, 2021

it add support for OLCI to read altitude

@ghislainp ghislainp requested a review from mraspaud as a code owner February 19, 2021 21:17
@ghislainp ghislainp changed the title add altitude in the list of dataset add altitude in the list of dataset for OLCI.nc Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1555 (d005e05) into master (e0f1fb8) will increase coverage by 0.52%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
+ Coverage   91.65%   92.17%   +0.52%     
==========================================
  Files         248      251       +3     
  Lines       36172    36764     +592     
==========================================
+ Hits        33155    33889     +734     
+ Misses       3017     2875     -142     
Flag Coverage Δ
behaviourtests 4.49% <9.65%> (+0.13%) ⬆️
unittests 92.71% <96.55%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/dataset/data_dict.py 90.09% <ø> (ø)
satpy/readers/ahi_hsd.py 96.86% <ø> (ø)
satpy/readers/ahi_l1b_gridded_bin.py 99.05% <ø> (ø)
satpy/readers/ami_l1b.py 96.99% <ø> (ø)
satpy/readers/fci_l2_nc.py 92.80% <ø> (ø)
satpy/readers/goes_imager_nc.py 65.46% <0.00%> (ø)
satpy/readers/iasi_l2_so2_bufr.py 94.62% <ø> (ø)
satpy/readers/mimic_TPW2_nc.py 80.95% <ø> (ø)
satpy/readers/nwcsaf_nc.py 60.40% <0.00%> (ø)
satpy/readers/olci_nc.py 91.42% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f1fb8...991e6f5. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added this to the v0.26.0 milestone Feb 25, 2021
@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Feb 25, 2021
@mraspaud mraspaud merged commit 2969c14 into pytroll:master Feb 25, 2021
@mraspaud mraspaud changed the title add altitude in the list of dataset for OLCI.nc Add altitude in the list of dataset for OLCI.nc Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants