-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch setuptools_scm to write version.py file #1512
Conversation
DeepCode's analysis on #217318 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Codecov Report
@@ Coverage Diff @@
## master #1512 +/- ##
=======================================
Coverage 91.62% 91.63%
=======================================
Files 246 246
Lines 36008 36004 -4
=======================================
- Hits 32993 32991 -2
+ Misses 3015 3013 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ok so what happens to the version number when:
|
This PR doesn't change anything about the existing behavior as far as local installations except for performance. The version number still doesn't update unless you re-install. This should fix the github zip/tarball installation now since that was previously not fully enabled (missing dependency). That means someone installing from a github release I think. |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking into this! sounds good with some import optimisation.
See #1509 for details. This should remove any overhead of using
pkg_resources
when importing satpy.