-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to FCI reader to include CT, CTTH, GII and the latest filenam… #1465
Conversation
…e formats for FCI L2 PF products
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
+ Coverage 90.52% 91.60% +1.08%
==========================================
Files 238 246 +8
Lines 34153 35964 +1811
==========================================
+ Hits 30916 32944 +2028
+ Misses 3237 3020 -217
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…e formats for FCI L2 PF products
…de from FCI L2 PF reader
DeepCode's analysis on #104db0 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
For the ASR data, it will return a 4 dimensional area for the product parameters. So eg scn.show('bt_mean') would not work , the user would have to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this PR, just a few suggestions and comments. Thanks for adding aaaaaaaall the new datasets!!!
Draft PR for the updates need for the FCI L2 PF to read the CT, CTTH, GII products and to use the latest product filename format
ASR to follow