-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary string decode in agri_l1 reader #1459
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
- Coverage 90.52% 90.52% -0.01%
==========================================
Files 238 238
Lines 34153 34149 -4
==========================================
- Hits 30916 30912 -4
Misses 3237 3237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @zxdawn recently ran into this issue as well. The main issue is newer versions of h5py loading/decoding strings differently. After investigating a bit with @zxdawn on slack, we weren't really sure why these strings were encoded with gbk
anyway since they are all ASCII characters.
I'm OK with this PR, but am still curious why these strings ever needed to be decoded specifically with gbk
in the first place.
@djhoese I can test different versions of h5py and report here later. |
@zxdawn any progress here? |
@mraspaud It's not related to the version of h5py. I have tested
Then, if I test
Anyway, LGTM for the newest satpy. |
Thanks. Looks good. |
This fixs a regression introduced by commit 14d9681.
flake8 satpy
AUTHORS.md
if not there already