Fix cloud-free pixels in cloudtop height composite #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
- Coverage 90.66% 90.66% -0.01%
==========================================
Files 236 236
Lines 33931 33941 +10
==========================================
+ Hits 30762 30771 +9
- Misses 3169 3170 +1
Continue to review full report at Codecov.
|
adybbroe
reviewed
Nov 13, 2020
| mapped_channels = colormap.colorize(data.data) | ||
| valid = status != status.attrs['_FillValue'] | ||
| # cloud-free pixels are marked invalid (fill_value in ctth_alti) but have status set to 1. | ||
| status_not_cloud_free = status % 2 == 0 |
There was a problem hiding this comment.
Isn't it only status=1 that indicates cloudfree?
Or is it a bit-flag?
adybbroe
reviewed
Nov 13, 2020
|
@adybbroe thanks for reviewing. It is a bit challenging to generate images from these file types sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the cloudtop height composite, that was considering the wrong pixels as invalid.