-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FIR product to seviri_l2_grib reader #1405
Add FIR product to seviri_l2_grib reader #1405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=======================================
Coverage 90.56% 90.57%
=======================================
Files 228 228
Lines 33406 33431 +25
=======================================
+ Hits 30254 30279 +25
Misses 3152 3152
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, just one minor comment/suggestion. Please add a link to the EUM Product Navigator (https://navigator.eumetsat.int/) to the references in seviri_l2_grib.py
and seviri_l2_bufr.py
.
Users can use the product navigator to find more info on EUM products, for example "what is the active fire classification? what do the numbers mean?".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR, and welcome to the Pytroll community! |
Add support of reading additional products to the seviri_l2_grid reader.
AUTHORS.md
if not there already