Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIR product to seviri_l2_grib reader #1405

Merged
merged 5 commits into from
Oct 23, 2020

Conversation

strandgren
Copy link
Collaborator

@strandgren strandgren commented Oct 16, 2020

Add support of reading additional products to the seviri_l2_grid reader.

  • Fully documented
  • Add your name to AUTHORS.md if not there already

@ameraner ameraner added component:readers enhancement code enhancements, features, improvements hacktoberfest labels Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1405 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1405   +/-   ##
=======================================
  Coverage   90.56%   90.57%           
=======================================
  Files         228      228           
  Lines       33406    33431   +25     
=======================================
+ Hits        30254    30279   +25     
  Misses       3152     3152           
Impacted Files Coverage Δ
satpy/readers/seviri_l2_grib.py 86.45% <ø> (ø)
satpy/readers/seviri_l2_bufr.py 93.90% <100.00%> (ø)
satpy/tests/reader_tests/test_mersi2_l1b.py 99.63% <0.00%> (+<0.01%) ⬆️
satpy/tests/test_composites.py 99.89% <0.00%> (+<0.01%) ⬆️
satpy/composites/__init__.py 82.80% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12917ab...65ca36b. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 16, 2020

Coverage Status

Coverage increased (+0.007%) to 90.572% when pulling 65ca36b on strandgren:feature_add_products_sev_grb into 12917ab on pytroll:master.

@strandgren strandgren changed the title Add additional products to seviri_l2_grib reader Add FIR product to seviri_l2_grib reader Oct 20, 2020
@strandgren strandgren marked this pull request as ready for review October 20, 2020 09:17
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR!

@sjoro sjoro self-requested a review October 20, 2020 09:38
Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, just one minor comment/suggestion. Please add a link to the EUM Product Navigator (https://navigator.eumetsat.int/) to the references in seviri_l2_grib.py and seviri_l2_bufr.py.
Users can use the product navigator to find more info on EUM products, for example "what is the active fire classification? what do the numbers mean?".

Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 9bb88cf into pytroll:master Oct 23, 2020
@mraspaud
Copy link
Member

Thanks for the PR, and welcome to the Pytroll community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants