-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update seviri icare tests #1342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 90.24% 90.39% +0.15%
==========================================
Files 222 228 +6
Lines 32719 33017 +298
==========================================
+ Hits 29526 29845 +319
+ Misses 3193 3172 -21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on adding the area and other attribute checks. Just some readability issues I'd like to clarify.
The seviri icare reader had poor test coverage, and quite a few things weren't being tested at all.
This PR updates the tests to fix the above, and now tests everything of importance.
flake8 satpy