Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aapp_l1b reader to behave nicely on missing datasets #1333

Merged
merged 5 commits into from
Sep 9, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Sep 1, 2020

This PR fixes the aapp_l1b reader to behave correctly on missing datasets (3a or 3b) and implements the available_datasets method.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1333 into master will increase coverage by 0.03%.
The diff coverage is 96.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
+ Coverage   90.24%   90.27%   +0.03%     
==========================================
  Files         222      222              
  Lines       32719    32788      +69     
==========================================
+ Hits        29526    29599      +73     
+ Misses       3193     3189       -4     
Impacted Files Coverage Δ
satpy/readers/aapp_l1b.py 89.38% <93.75%> (+3.10%) ⬆️
satpy/tests/reader_tests/test_aapp_l1b.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280d863...3b7986a. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 1, 2020

Coverage Status

Coverage increased (+0.03%) to 90.274% when pulling 3b7986a on mraspaud:fix-aapp-channels-availability into e77cd29 on pytroll:master.

@mraspaud mraspaud marked this pull request as ready for review September 9, 2020 10:31
@mraspaud
Copy link
Member Author

mraspaud commented Sep 9, 2020

@pnuu could you take a few minutes to test this PR?

@mraspaud mraspaud added this to the v0.23.0 milestone Sep 9, 2020
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available datasets looks good to me.

@mraspaud mraspaud merged commit 25ba900 into pytroll:master Sep 9, 2020
@mraspaud mraspaud deleted the fix-aapp-channels-availability branch September 9, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AAPP AVHRR level 1 reader raises a Value error when a channel is missing
3 participants