Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time extraction from filenames in yaml for SEVIRI Native and NetCDF readers #1318

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

ameraner
Copy link
Member

This PR fixes the start/end/processing time extraction from filenames in the yaml file_patterns for the SEVIRI native and netcdf readers.

  • Tests passed

@ameraner
Copy link
Member Author

For the full discussion on this with @djhoese see Slack messages .

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be nice to have a test for group_files for this, but I think that might need a larger scale set of tests that are out of scope for this PR (ex. testing every readers files with group_files).

@coveralls
Copy link

coveralls commented Aug 19, 2020

Coverage Status

Coverage remained the same at 90.065% when pulling 2117692 on ameraner:fix-native_filename_yaml_pattern into 452f8ad on pytroll:master.

Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #1318 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1318   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         220      220           
  Lines       32420    32420           
=======================================
  Hits        29199    29199           
  Misses       3221     3221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452f8ad...2117692. Read the comment docs.

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@mraspaud mraspaud merged commit b7f052a into pytroll:master Aug 21, 2020
@ameraner ameraner deleted the fix-native_filename_yaml_pattern branch December 7, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants