-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time extraction from filenames in yaml for SEVIRI Native and NetCDF readers #1318
Fix time extraction from filenames in yaml for SEVIRI Native and NetCDF readers #1318
Conversation
For the full discussion on this with @djhoese see Slack messages . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Might be nice to have a test for group_files
for this, but I think that might need a larger scale set of tests that are out of scope for this PR (ex. testing every readers files with group_files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 220 220
Lines 32420 32420
=======================================
Hits 29199 29199
Misses 3221 3221 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
This PR fixes the start/end/processing time extraction from filenames in the yaml
file_patterns
for the SEVIRI native and netcdf readers.