Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on i386 #1315

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix tests on i386 #1315

merged 1 commit into from
Aug 18, 2020

Conversation

avalentino
Copy link
Contributor

@avalentino avalentino commented Aug 18, 2020

@mraspaud
Copy link
Member

LGTM, good catch!

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 90.062% when pulling 56e1018 on avalentino:fix-tests-on-i386 into 1ea1383 on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 90.062% when pulling 56e1018 on avalentino:fix-tests-on-i386 into 1ea1383 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1315 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   90.06%   90.06%   -0.01%     
==========================================
  Files         220      220              
  Lines       32419    32420       +1     
==========================================
  Hits        29198    29198              
- Misses       3221     3222       +1     
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l1b_hrit.py 100.00% <100.00%> (ø)
satpy/scene.py 90.34% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea1383...56e1018. Read the comment docs.

@mraspaud mraspaud merged commit e0773c4 into pytroll:master Aug 18, 2020
@avalentino avalentino deleted the fix-tests-on-i386 branch August 18, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants