-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix true colors generation for AHI HSD data and refactor the dep tree code #1313
Conversation
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
==========================================
+ Coverage 90.06% 90.24% +0.17%
==========================================
Files 220 222 +2
Lines 32419 32719 +300
==========================================
+ Hits 29198 29526 +328
+ Misses 3221 3193 -28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this transitive change on resolution you'll need to update the dev guide docs which use resolution as an example.
I also don't use transitive in my everyday vocabulary (I don't have a very large one) but I'm confused at which definition of transitive fits here with how it is being used.
The idea is that if the compositor |
For example full MODIS datasets provide the same data at multiple resolution. The right resolution has to be used if the user has requested a specific resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything wrong with this. I'm sure there will be surprises, but better to have more things working and getting towards a fully working redesign/refactor. I had one comment about the new exception but otherwise I'll just ask for a self-review of the new methods you added to everything and make sure that they actually need to be public. Otherwise LGTM.
I think things are in order with public/private |
Refactor the dep tree code and fix the true color composite for instruments with channels at different resolutions.
flake8 satpy