Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix (FY4A AGRI): Correct the type of orbital_parameters to float #1244

Merged
merged 7 commits into from
Jun 30, 2020
Merged

Bugfix (FY4A AGRI): Correct the type of orbital_parameters to float #1244

merged 7 commits into from
Jun 30, 2020

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented Jun 29, 2020 •
edited by pnuu
Loading

@zxdawn zxdawn requested review from djhoese and mraspaud as code owners June 29, 2020 02:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 90.028% when pulling 0e7a56a on zxdawn:fy4a into 9261a1c on pytroll:master.

@coveralls
Copy link

coveralls commented Jun 29, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 90.028% when pulling 2f130f2 on zxdawn:fy4a into 9261a1c on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #1244 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1244   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         218      218           
  Lines       31263    31269    +6     
=======================================
+ Hits        28145    28151    +6     
  Misses       3118     3118
Impacted Files Coverage Δ
satpy/readers/agri_l1.py 99.18% <ø> (ø)
satpy/tests/reader_tests/test_agri_l1.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9261a1c...2f130f2. Read the comment docs.

sfinkens
sfinkens approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you! Just one little wish.

@sfinkens
Copy link
Member

Looks good to me now!

mraspaud
mraspaud approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit b909413 into pytroll:master Jun 30, 2020
@zxdawn zxdawn deleted the fy4a branch July 1, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfinkens sfinkens sfinkens approved these changes

@mraspaud mraspaud mraspaud approved these changes

@djhoese djhoese Awaiting requested review from djhoese

Assignees

@zxdawn zxdawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong data type of orbital_parameters in FY4A AGRI reader
5 participants
@zxdawn @coveralls @sfinkens @mraspaud @pnuu