Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables handeling to static image compositor #1241

Conversation

nedelceo
Copy link
Contributor

@nedelceo nedelceo commented Jun 25, 2020

Same as #1239, which was mistakenly closed by me. Sorry for that.
This PR allows usage of environment variables in StaticImageCompositor.

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for you contribution!

@coveralls
Copy link

coveralls commented Jun 25, 2020

Coverage Status

Coverage increased (+0.004%) to 90.027% when pulling da062c3 on nedelceo:Add_environment_variables_handeling_to_StaticImageCompositor into 4b92a3c on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1241 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1241   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         218      218           
  Lines       31259    31263    +4     
=======================================
+ Hits        28141    28145    +4     
  Misses       3118     3118           
Impacted Files Coverage Δ
satpy/composites/__init__.py 80.70% <100.00%> (ø)
satpy/tests/test_composites.py 99.88% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b92a3c...da062c3. Read the comment docs.

@mraspaud
Copy link
Member

@nedelceo one thing we missed I think: did you add you name to authors.md?

@mraspaud mraspaud added component:scene enhancement code enhancements, features, improvements labels Jun 26, 2020
@mraspaud mraspaud merged commit 9261a1c into pytroll:master Jun 26, 2020
@djhoese
Copy link
Member

djhoese commented Jun 29, 2020

@nedelceo For future reference, you should be able to reopen a closed PR and you can add new commits to an existing PR to make updates to it. Now that this is merged though, you'll need to make a separate PR to add yourself to the AUTHORS.md file.

Edit: Nevermind, it seems you already did the authors.md stuff. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scene enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants