-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variables handeling to static image compositor #1241
Add environment variables handeling to static image compositor #1241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for you contribution!
Codecov Report
@@ Coverage Diff @@
## master #1241 +/- ##
=======================================
Coverage 90.02% 90.02%
=======================================
Files 218 218
Lines 31259 31263 +4
=======================================
+ Hits 28141 28145 +4
Misses 3118 3118
Continue to review full report at Codecov.
|
@nedelceo one thing we missed I think: did you add you name to authors.md? |
@nedelceo For future reference, you should be able to reopen a closed PR Edit: Nevermind, it seems you already did the authors.md stuff. Thanks. |
Same as #1239, which was mistakenly closed by me. Sorry for that.
This PR allows usage of environment variables in StaticImageCompositor.
flake8 satpy