Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCI: fix areadef when only pixel quality asked #1230

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

gerritholl
Copy link
Member

@gerritholl gerritholl commented Jun 4, 2020

When reading only pixel quality fields from FCI, make sure it can still
correctly calculate the area definition. Closes #1229.

When reading only pixel quality fields from FCI, make sure it can still
correctly calculate the area definition.  Closes pytroll#1229.
@gerritholl gerritholl requested a review from mraspaud as a code owner June 4, 2020 08:20
@gerritholl gerritholl marked this pull request as draft June 4, 2020 08:22
Add a unit test ensuring that reading only pixel quality works for FCI.
@gerritholl gerritholl marked this pull request as ready for review June 4, 2020 08:29
@gerritholl gerritholl requested a review from djhoese as a code owner June 4, 2020 08:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 89.957% when pulling d690abe on gerritholl:fci-read-quality-first into e10908a on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #1230 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         208      208           
  Lines       30587    30598   +11     
=======================================
+ Hits        27514    27525   +11     
  Misses       3073     3073           
Impacted Files Coverage Δ
satpy/readers/fci_l1c_fdhsi.py 98.10% <100.00%> (+0.03%) ⬆️
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10908a...d690abe. Read the comment docs.

@gerritholl
Copy link
Member Author

Apparently, this also avoids the segmentation fault reported in pytroll/pyresample#274

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FCI reader can read pixel_quality flags only after reading corresponding channel data
3 participants