-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an error if data and angle shapes don't match in NIRReflectance #1107
Conversation
This should probably use |
Oh there are a couple compositors that don't use this. Thoughts on adding this to all of them? |
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 89.34% 89.32% -0.02%
==========================================
Files 195 195
Lines 28785 28790 +5
==========================================
+ Hits 25717 25718 +1
- Misses 3068 3072 +4
Continue to review full report at Codecov.
|
Oh, that was a new method to me! I've changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this, I stumble upon it myself recently.
This is a fix to a minor bug that I encountered when using
nir_reflectance
modifier with VIIRS SDR data. By default Satpy loads the highest resolution (I
channel) datasets, and when this modifier is used in a composite usingM
-channel data there's a crash because the arrays have different shapes.Naturally, the correct way to define the composite is to use the
nir_reflectance_lowres
modifier where the proper resolution is defined.flake8 satpy