Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around changes in xarray 0.15 #1058

Merged
merged 3 commits into from
Feb 4, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Feb 4, 2020

Xarray v0.15.0 brings some changes that broke the satpy unit tests.
Here we provide a fix for coarsen and use drop_vars in instead of del:
pydata/xarray#3746

  • Tests passed
  • Passes flake8 satpy

@mraspaud mraspaud added the bug label Feb 4, 2020
@mraspaud mraspaud requested a review from djhoese February 4, 2020 11:17
@mraspaud mraspaud self-assigned this Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1c4c43c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1058   +/-   ##
=========================================
  Coverage          ?   88.09%           
=========================================
  Files             ?      191           
  Lines             ?    29438           
  Branches          ?        0           
=========================================
  Hits              ?    25934           
  Misses            ?     3504           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/tests/compositor_tests/__init__.py 99.61% <100%> (ø)
satpy/readers/abi_base.py 91.79% <100%> (ø)
satpy/readers/scmi.py 82.91% <100%> (ø)
satpy/scene.py 89.91% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4c43c...3b2e0b4. Read the comment docs.

@mraspaud
Copy link
Member Author

mraspaud commented Feb 4, 2020

I think this should be squash-merged

@djhoese
Copy link
Member

djhoese commented Feb 4, 2020

If this passes tests, is it ready for merge?

Based on the changes, I assume you searched for del ...coords['coord'] usage?

@mraspaud
Copy link
Member Author

mraspaud commented Feb 4, 2020

Yes, and yes.

@mraspaud mraspaud merged commit 807b150 into pytroll:master Feb 4, 2020
@mraspaud mraspaud deleted the fix-dependencies-updates branch February 4, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants