Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowercase the sensor name #1057

Merged
merged 2 commits into from
Feb 4, 2020
Merged

lowercase the sensor name #1057

merged 2 commits into from
Feb 4, 2020

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented Feb 4, 2020

Lowercase the AGRI sensor name to make sure enhancement file works well with lowercase: agri.yaml.

@mraspaud
Copy link
Member

mraspaud commented Feb 4, 2020

How about adding a small test for this ?

mraspaud
mraspaud approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit df222bd into pytroll:master Feb 4, 2020
@zxdawn zxdawn deleted the add_fy4a branch June 29, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

@djhoese djhoese Awaiting requested review from djhoese

Assignees

@zxdawn zxdawn

Labels
bug component:readers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxdawn @mraspaud