Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scatsat1_l2b and caliop_l2_cloud readers fail to initialise due to failed Dataset import #2311

Closed
ameraner opened this issue Dec 5, 2022 · 2 comments

Comments

@ameraner
Copy link
Member

ameraner commented Dec 5, 2022

Describe the bug
Some readers fail to initialise due to the broken import from satpy.dataset import Dataset (hasn't been around for a long while already).

To Reproduce

import satpy
from satpy.utils import debug_on; debug_on()
readers = satpy.available_readers()

Expected behavior
All readers should initialise fine and appear in the output list.

Actual results
Some readers, particularly scatsat1_l2b and caliop_l2_cloud fail at the Dataset import.

  File "/tcenas/home/andream/code/satpy_latest/satpy/satpy/readers/scatsat1_l2b.py", line 24, in <module>
    from satpy.dataset import Dataset
ImportError: cannot import name 'Dataset' from 'satpy.dataset' (/tcenas/home/andream/code/satpy_latest/satpy/satpy/dataset/__init__.py)

[..]

  File "/tcenas/home/andream/code/satpy_latest/satpy/satpy/readers/caliop_l2_cloud.py", line 28, in <module>
    from satpy.dataset import Dataset
ImportError: cannot import name 'Dataset' from 'satpy.dataset' (/tcenas/home/andream/code/satpy_latest/satpy/satpy/dataset/__init__.py)

[..]

  File "/tcenas/home/andream/code/satpy_latest/satpy/satpy/readers/li_l2.py", line 35, in <module>
    from satpy.dataset import Dataset
ImportError: cannot import name 'Dataset' from 'satpy.dataset' (/tcenas/home/andream/code/satpy_latest/satpy/satpy/dataset/__init__.py)

Note that the li_l2 reader is being removed/rewritten in #2271 .

@djhoese
Copy link
Member

djhoese commented Dec 5, 2022

I could have sworn there was an issue for these readers, but the bottom line is that these readers are not updated to work with xarray/dask. They are using the Dataset class that existed before we migrated to xarray and dask. So it isn't as simple as a "missing dependency" like some readers might have. These readers are completely defunct and will not work with modern Satpy.

@ameraner
Copy link
Member Author

ameraner commented Dec 5, 2022

Ah, in my previous search attempt I didn't find it, but there is an issue already indeed (#1377). So I'll close this, sorry for the noise.

@ameraner ameraner closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants