You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I'm creating a Scene that contains both ABI L1B and GLM files. I'm experimenting with #1321 and trying to get ABI L1B from a remote filesystem but GLM files locally. This means I need to pass different values for the same keyword argument to the ABI reader than to the GLM reader, in particular a different value for file_system. However, currently the Scene class passes the same reader_kwargs to each reader.
Describe the solution you'd like
I would like an API where the user can specify the reader_kwargs separately for each reader, possibly with an interface like:
This could be implemented with little to no backward compatibility problems, although there may be problems in corner cases. If multiple readers are passed, the Scene class could guess whether the old or new API for reader_kwargs is passed. If the keys for reader_kwargs correspond exactly to the readers and the values are all dictionaries, it can guess that reader_kwargs is very likely provided separately for each reader. It would seem very unlikely that this guess is ever incorrect.
Additional context
A workaround would be for me to create each Scene object separately, then merge them.
The text was updated successfully, but these errors were encountered:
Feature Request
Is your feature request related to a problem? Please describe.
I'm creating a
Scene
that contains both ABI L1B and GLM files. I'm experimenting with #1321 and trying to get ABI L1B from a remote filesystem but GLM files locally. This means I need to pass different values for the same keyword argument to the ABI reader than to the GLM reader, in particular a different value forfile_system
. However, currently theScene
class passes the samereader_kwargs
to each reader.Describe the solution you'd like
I would like an API where the user can specify the
reader_kwargs
separately for each reader, possibly with an interface like:Describe any changes to existing user workflow
This could be implemented with little to no backward compatibility problems, although there may be problems in corner cases. If multiple readers are passed, the
Scene
class could guess whether the old or new API forreader_kwargs
is passed. If the keys forreader_kwargs
correspond exactly to the readers and the values are all dictionaries, it can guess thatreader_kwargs
is very likely provided separately for each reader. It would seem very unlikely that this guess is ever incorrect.Additional context
A workaround would be for me to create each
Scene
object separately, then merge them.The text was updated successfully, but these errors were encountered: