Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install[complete] vs pip install[all] #1350

Closed
raybellwaves opened this issue Sep 7, 2020 · 2 comments
Closed

pip install[complete] vs pip install[all] #1350

raybellwaves opened this issue Sep 7, 2020 · 2 comments

Comments

@raybellwaves
Copy link
Contributor

raybellwaves commented Sep 7, 2020

In the install instructions it says pip install satpy[all]
https://satpy.readthedocs.io/en/latest/install.html#pip-based-installation

I'm used to using pip install satpy[complete] e.g. (https://docs.dask.org/en/latest/install.html#pip)

and this seems to get you further that using [all] (in a python3.8 environment: (#1346 (comment)

Check (use py 3.7?)

$ conda create -n test_env python=3.7
$ conda activate test_env
$ pip install "satpy[all]"
$ conda remove --name test_env --all
$ conda create -n test_env python=3.7
$ conda activate test_env
$ pip install "satpy[complete]"
@djhoese
Copy link
Member

djhoese commented Sep 7, 2020

It gets you further because complete doesn't actually exist in the setup.py. See here for dask: https://github.com/dask/dask/blob/master/setup.py#L29

They have a complete extra, we have a all extra:

https://github.com/pytroll/satpy/blob/master/setup.py#L79

The bug then in this case is that pip isn't complaining about an extra that doesn't exist.

Edit: My guess is that if it doesn't exist pip is just installing the base dependencies which is why it gets further in the installation process (less deps).

@raybellwaves
Copy link
Contributor Author

Understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants