Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amsr2 l1b reader also match amsr2 l2 products #1151

Closed
TAlonglong opened this issue Apr 17, 2020 · 2 comments · Fixed by #1152
Closed

amsr2 l1b reader also match amsr2 l2 products #1151

TAlonglong opened this issue Apr 17, 2020 · 2 comments · Fixed by #1152
Labels
component:readers enhancement code enhancements, features, improvements

Comments

@TAlonglong
Copy link
Collaborator

TAlonglong commented Apr 17, 2020

the amsr2 l1b reader also match amsr2 l2 products

l1b filename: GW1AM2_202004171159_065B_L1SNBTBR_2220220.h5
l2 filename: GW1AM2_202004161432_090B_L2SNSSWLB3300300.h5

I'm looking into add reading of the L2 SSW product and this needs some small updates to the l1b reader to make it work.

Should I update the l1b reader or should I create a amsr2_l2 reader mostly the same as the l1b reader?

If I create a new reader we need to update the l1b reader to only match L1 data

@TAlonglong
Copy link
Collaborator Author

amsr2-ssw

Just a quick example of the SSW data

@djhoese
Copy link
Member

djhoese commented Apr 17, 2020

I think my preference would be to make a separate reader but just use the same python code (point the YAML to the same python module). If needed, subclass the python class in to a new amsr2_l2.py module.

@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants