Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize area def computation in goes_imager_hrit #1022

Closed
sfinkens opened this issue Dec 17, 2019 · 1 comment · Fixed by #1934
Closed

Factorize area def computation in goes_imager_hrit #1022

sfinkens opened this issue Dec 17, 2019 · 1 comment · Fixed by #1934
Labels
component:readers enhancement code enhancements, features, improvements

Comments

@sfinkens
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe.
HRITMSGFileHandler now has two methods _get_area_extent and get_area_extent to compute the area extent. The latter is inherited from HRITFileHandler and yields incorrect results for SEVIRI.

Describe the solution you'd like
The only reader using HRITFileHandler.get_area_extent is HRITGOESFileHandler. So we could remove that method and use the new helper methods from satpy.readers._geos_area in HRITGOESFileHandler instead.

Describe any changes to existing user workflow
None

Additional context
None
@sfinkens sfinkens added enhancement code enhancements, features, improvements component:readers labels Dec 17, 2019
@sfinkens
Copy link
Member Author

sfinkens commented Dec 17, 2019 •
edited
Loading

@simonrp84 is willing to work on this in 2020

@sfinkens sfinkens mentioned this issue Dec 12, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Factorize area computation in goes_imager_hrit sfinkens/satpy
1 participant
@sfinkens