-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compute method to Scene #1015
Comments
I think it would best to reflect the xarray interfaces for this. My hope is in the future that the |
Hey @djhoese you are right and most of the time I am actually using persist. Yes I think reflecting the interfaces was basically what I wanted to say. The replacement with xarray Datasets would be nice I think I talked about this with @mraspaud during the meeting at Eumetsat in Darmstadt last year in the context of the Multiscene and the DatasetID. Sometime ago I started a list with some changes that would be needed as far as I could see but I can't find it right now. Is there a "timeline" if and when this transition is roughly planned or has somebody started development on this already? |
I think the example code you have above is good and should be used for persist and compute. There is no timeline for moving the Scene to be more xarray.Dataset-y. There are too many things that the Scene can do that don't fit in the generic "container" style of an xarray Dataset (composite dependency handling and generation is the big one). It is just something I'm keeping in mind as we continue forward with features. Even if the Scene was transitioned to be a Dataset, the interfaces currently established would have to be preserved for at least a couple versions if we don't want to completely anger the entire userbase. |
Feature Request
Sometimes I am in the situation that I need to compute all DataAarrays in the Scene. For example if I want to use a resampled Scene in two different processing streams and don't want to calculate the resampling twice.
Describe the solution you'd like
The Scene could have a "compute()" method which just calls "compute()" on each DataArray:
Maybe this can even be more generic like an "apply" method. This could then be used for all DataArray methods like "chunks()" etc.
Describe any changes to existing user workflow
This would not change the existing user workflows.
The text was updated successfully, but these errors were encountered: