Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed cleanup in last PR #46

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

mraspaud
Copy link
Member

This PR cleans up missed rests of the refactoring done previously in #45

@mraspaud mraspaud added the bug label Oct 20, 2022
@mraspaud mraspaud requested a review from pnuu October 20, 2022 07:12
@mraspaud mraspaud self-assigned this Oct 20, 2022
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #46 (ac99db7) into main (db33805) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   79.24%   79.18%   -0.07%     
==========================================
  Files          14       14              
  Lines        2101     2099       -2     
==========================================
- Hits         1665     1662       -3     
- Misses        436      437       +1     
Impacted Files Coverage Δ
posttroll/tests/test_pubsub.py 96.61% <ø> (-0.02%) ⬇️
posttroll/subscriber.py 90.83% <0.00%> (-0.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pnuu pnuu merged commit 6ad5116 into pytroll:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants