Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use donfig for handling posttroll environment variables #45

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

mraspaud
Copy link
Member

This PR makes use of donfig to handle posttroll configuration

@mraspaud mraspaud requested a review from djhoese October 19, 2022 12:35
@mraspaud mraspaud self-assigned this Oct 19, 2022
@mraspaud mraspaud requested a review from pnuu October 19, 2022 12:36
@pnuu
Copy link
Member

pnuu commented Oct 19, 2022

We also have NAMESERVER_PORT and DEBUG environment variables. But I guess Donfig only handle variables that are prefixed?

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and otherwise LGTM

@pnuu
Copy link
Member

pnuu commented Oct 19, 2022

It seems that the new environment variable handling isn't working for defining the min/max port range 🤔

@mraspaud
Copy link
Member Author

Really? Test was passing locally...

@mraspaud
Copy link
Member Author

We also have NAMESERVER_PORT and DEBUG environment variables. But I guess Donfig only handle variables that are prefixed?

Yes indeed. So that would need a longer process of deprecation.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #45 (db33805) into main (a2b6e69) will increase coverage by 0.58%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   78.66%   79.24%   +0.58%     
==========================================
  Files          14       14              
  Lines        2086     2101      +15     
==========================================
+ Hits         1641     1665      +24     
+ Misses        445      436       -9     
Impacted Files Coverage Δ
posttroll/tests/test_pubsub.py 96.63% <94.73%> (+0.10%) ⬆️
posttroll/publisher.py 97.72% <100.00%> (+0.01%) ⬆️
posttroll/version.py 39.54% <0.00%> (+2.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pnuu pnuu merged commit 66e1d80 into pytroll:main Oct 19, 2022
@mraspaud mraspaud deleted the feature-donfig branch October 20, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants