-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use donfig for handling posttroll environment variables #45
Conversation
We also have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and otherwise LGTM
It seems that the new environment variable handling isn't working for defining the min/max port range 🤔 |
Really? Test was passing locally... |
Yes indeed. So that would need a longer process of deprecation. |
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 78.66% 79.24% +0.58%
==========================================
Files 14 14
Lines 2086 2101 +15
==========================================
+ Hits 1641 1665 +24
+ Misses 445 436 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR makes use of donfig to handle posttroll configuration