Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutmix alpha argument in references/classification/transforms.py #8440

Closed
eminorhan opened this issue May 25, 2024 · 1 comment · Fixed by #8448
Closed

cutmix alpha argument in references/classification/transforms.py #8440

eminorhan opened this issue May 25, 2024 · 1 comment · Fixed by #8448

Comments

@eminorhan
Copy link
Contributor

I believe the alpha argument here should be cutmix_alpha not mixup_alpha:

transforms_module.CutMix(alpha=mixup_alpha, num_classes=num_classes)

Same issue here as well:

else RandomCutMix(num_classes=num_classes, p=1.0, alpha=mixup_alpha)

Just curious: were the pretrained models actually trained using this code? Any chance this might have affected the performance of the pretrained models in any way?

@NicolasHug
Copy link
Member

NicolasHug commented May 28, 2024

Great catch @eminorhan , thanks a lot for the report. Would you like to submit a PR to fix these 2 lines?

were the pretrained models actually trained using this code? Any chance this might have affected the performance of the pretrained models in any way?

The bug was introduced in #7731, but all the models we have published in torchvision were trained prior to that change, so the bug doesn't affect the models available within torchvision. However, it may have affected models trained by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants