Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify torch.utils.cpp_extension.include_paths; use it in cpp_builder #145480

Closed
wants to merge 1 commit into from
Closed

simplify torch.utils.cpp_extension.include_paths; use it in cpp_builder #145480

wants to merge 1 commit into from

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Jan 23, 2025 •
edited by pytorch-bot bot
Loading

While working on conda-forge integration, I needed to look at the way the include paths are calculated, and noticed an avoidable duplication between torch/utils/cpp_extension.py and torch/_inductor/cpp_builder.py. The latter already imports the former anyway, so simply reuse the same function.

Furthermore, remove long-obsolete include-paths. AFAICT, the /TH headers have not existed since pytorch 1.11.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145480

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 074cb61 with merge base 46e06e1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 23, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@h-vetinari
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 23, 2025
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 24, 2025
@ezyang
Copy link
Contributor

ezyang commented Jan 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 16:39 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 16:39 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 24, 2025 16:39 Inactive
@ezyang
Copy link
Contributor

ezyang commented Jan 25, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@h-vetinari @pytorchmergebot
simplify torch.utils.cpp_extension.include_paths; use it in cpp_builder
074cb61 
The /TH headers have not existed since pytorch 1.11
@pytorchmergebot
Copy link
Collaborator

Successfully rebased headers onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout headers && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 25, 2025 03:54 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 25, 2025 03:54 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 25, 2025 03:54 Inactive
@ezyang
Copy link
Contributor

ezyang commented Jan 27, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@h-vetinari h-vetinari deleted the headers branch January 27, 2025 08:02
pytorchmergebot pushed a commit to ROCm/pytorch that referenced this pull request Jan 27, 2025
@h-vetinari @pytorchmergebot
simplify torch.utils.cpp_extension.include_paths; use it in cpp_build…
bff5b67 
…er (pytorch#145480)

While working on conda-forge integration, I needed to look at the way the include paths are calculated, and noticed an avoidable duplication between `torch/utils/cpp_extension.py` and `torch/_inductor/cpp_builder.py`. The latter already imports the former anyway, so simply reuse the same function.

Furthermore, remove long-obsolete include-paths. AFAICT, the `/TH` headers have not existed since pytorch 1.11.

Pull Request resolved: pytorch#145480
Approved by: https://github.com/ezyang
nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request Jan 27, 2025
@h-vetinari @nWEIdia
simplify torch.utils.cpp_extension.include_paths; use it in cpp_build…
cfdfdd4 
…er (pytorch#145480)

While working on conda-forge integration, I needed to look at the way the include paths are calculated, and noticed an avoidable duplication between `torch/utils/cpp_extension.py` and `torch/_inductor/cpp_builder.py`. The latter already imports the former anyway, so simply reuse the same function.

Furthermore, remove long-obsolete include-paths. AFAICT, the `/TH` headers have not existed since pytorch 1.11.

Pull Request resolved: pytorch#145480
Approved by: https://github.com/ezyang
@h-vetinari h-vetinari mentioned this pull request Feb 11, 2025
Merged
Tytskiy pushed a commit to Tytskiy/pytorch that referenced this pull request Feb 18, 2025
@h-vetinari @Tytskiy
simplify torch.utils.cpp_extension.include_paths; use it in cpp_build…
a8163f8 
…er (pytorch#145480)

While working on conda-forge integration, I needed to look at the way the include paths are calculated, and noticed an avoidable duplication between `torch/utils/cpp_extension.py` and `torch/_inductor/cpp_builder.py`. The latter already imports the former anyway, so simply reuse the same function.

Furthermore, remove long-obsolete include-paths. AFAICT, the `/TH` headers have not existed since pytorch 1.11.

Pull Request resolved: pytorch#145480
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@fmassa fmassa Awaiting requested review from fmassa fmassa is a code owner

@soumith soumith Awaiting requested review from soumith soumith is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-vetinari @ezyang @pytorchmergebot @cpuhrsch @pytorchbot