Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy failing #434

Closed
FFY00 opened this issue Mar 10, 2023 · 0 comments · Fixed by #435
Closed

mypy failing #434

FFY00 opened this issue Mar 10, 2023 · 0 comments · Fixed by #435
Labels
bug Something isn't working

Comments

@FFY00
Copy link
Member

FFY00 commented Mar 10, 2023

mypy is failing in the tests with the following error

435: error: Incompatible return value type (got "Message", expected "PackageMetadata")  [return-value]
435: note: Following member(s) of "Message" have conflicts:
435: note:     Expected:
435: note:         def [_T] get_all(self, name: str, failobj: _T = ...) -> Union[List[Any], _T]
435: note:     Got:
435: note:         @overload
435: note:         def get_all(self, name: str, failobj: None = ...) -> Optional[List[Any]]
435: note:         @overload
435: note:         def [_T] get_all(self, name: str, failobj: _T) -> Union[List[Any], _T]

The typeshed definitions changed in python/typeshed@b5a26d1, causing PackageMetadata to fall out of sync. I think the right option here is just to bring PackageMetadata back in sync with email.message.Message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant