Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-22295: use python -m pip rather than plain pip in examples #24003

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Dec 29, 2020


.. code-block:: bash

(tutorial-env) $ pip show requests
(tutorial-env) $ python -m pip show requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples already in a virtual environment should not be changed because the whole point of the environment is to make sure the correct python and pip are being targeted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can revert those if that's what it takes to get this merged (please confirm), but would like to point out first that

  • they will then be the only places referring to the pip executable rather than python -m pip which might be a surprise to some readers, it gets more rare and there's no explanation for it, and
  • the point of using python -m pip instead of pip is just as valid in virtual envs as it is outside of them

@github-actions
Copy link

github-actions bot commented Feb 2, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 2, 2021
@scop
Copy link
Contributor Author

scop commented Feb 2, 2021

Pending @rhettinger comments above, not stale as far as I'm concerned.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 5, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 5, 2021
@scop
Copy link
Contributor Author

scop commented Mar 5, 2021

Still not stale I think, see above.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Mar 6, 2021
@hugovk
Copy link
Member

hugovk commented Feb 12, 2022

Please edit the PR title to begin with [bpo-22295](https://bugs.python.org/issue22295):

https://devguide.python.org/pullrequest/#submitting

@scop scop changed the title Doc: use python -m pip rather than plain pip in examples [bpo-22295](https://bugs.python.org/issue22295) use python -m pip rather than plain pip in examples Feb 14, 2022
@hugovk
Copy link
Member

hugovk commented Apr 9, 2022

Please edit the PR title to begin with [bpo-22295](https://bugs.python.org/issue22295):

devguide.python.org/pullrequest/#submitting

Oops, the bot edited my comment to add a Markdown link, I meant just the xyz-12345 bit :)

@scop scop changed the title [bpo-22295](https://bugs.python.org/issue22295) use python -m pip rather than plain pip in examples bpo-22295: use python -m pip rather than plain pip in examples Apr 9, 2022
@scop
Copy link
Contributor Author

scop commented Apr 9, 2022

Tweaked title, resolved conflicts.

@ned-deily
Copy link
Member

LGTM. Now all examples consistently use python -m pip. Thanks, @scop, for the PR and, @hugovk, for nudging it along.

@ned-deily ned-deily merged commit dc14e33 into python:main Apr 9, 2022
@scop scop deleted the python-m-pip branch April 9, 2022 19:23
guyer added a commit to usnistgov/fipy that referenced this pull request May 20, 2022
* Install twine for package tests

* Remove bdist_wininst

   - Addresses #858

* Merge unix and windows source distribution

    Remove win executable

* Merge source builds

* Document wheel upload

* Update to preferred pip invocation

    - https://docs.python.org/3/installing/index.html#basic-usage
    - https://bugs.python.org/issue22295
    - python/cpython#24003

* Organize and name distribution files more consistently

* Publish docs as separate artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants