-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-22295: use python -m pip
rather than plain pip
in examples
#24003
Conversation
|
||
.. code-block:: bash | ||
|
||
(tutorial-env) $ pip show requests | ||
(tutorial-env) $ python -m pip show requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples already in a virtual environment should not be changed because the whole point of the environment is to make sure the correct python and pip are being targeted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revert those if that's what it takes to get this merged (please confirm), but would like to point out first that
- they will then be the only places referring to the
pip
executable rather thanpython -m pip
which might be a surprise to some readers, it gets more rare and there's no explanation for it, and - the point of using
python -m pip
instead ofpip
is just as valid in virtual envs as it is outside of them
This PR is stale because it has been open for 30 days with no activity. |
Pending @rhettinger comments above, not stale as far as I'm concerned. |
This PR is stale because it has been open for 30 days with no activity. |
Still not stale I think, see above. |
Please edit the PR title to begin with |
python -m pip
rather than plain pip
in examplespython -m pip
rather than plain pip
in examples
Oops, the bot edited my comment to add a Markdown link, I meant just the |
python -m pip
rather than plain pip
in examplespython -m pip
rather than plain pip
in examples
Tweaked title, resolved conflicts. |
* Install twine for package tests * Remove bdist_wininst - Addresses #858 * Merge unix and windows source distribution Remove win executable * Merge source builds * Document wheel upload * Update to preferred pip invocation - https://docs.python.org/3/installing/index.html#basic-usage - https://bugs.python.org/issue22295 - python/cpython#24003 * Organize and name distribution files more consistently * Publish docs as separate artifact
Refs https://bugs.python.org/issue22295
https://bugs.python.org/issue22295