Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to handle DECREF_INPUTS_AND_REUSE_FLOAT with deferred floats? #118930

Closed
Tracked by #117139
Fidget-Spinner opened this issue May 10, 2024 · 1 comment
Closed
Tracked by #117139

How to handle DECREF_INPUTS_AND_REUSE_FLOAT with deferred floats? #118930

Fidget-Spinner opened this issue May 10, 2024 · 1 comment

Comments

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented May 10, 2024 •
edited
Loading

DECREF_INPUTS_AND_REUSE_FLOAT and _Py_DECREF_SPECIALIZED are problematic in that they don't follow standard CPython reference semantics that we plan for the deferred refcounting.

The easiest solution would be to get rid of them. I don't know what's the perf hit from something like that, and whether we can recover it though.
This was referenced May 10, 2024
Closed
Merged
@Fidget-Spinner
Copy link
Member Author

Handled by abstracting them in another function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fidget-Spinner