You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recent upgrade of this library broke our site, as the existing public=True is now breaking every url validation.
Couple of problems I'd like to mention:
This is a breaking change. Every code which has url(..., public=...) is now broken, but silently. By silently I mean that the URLs are all failing validation, without any warning lines, etc. to let the developer know that this breaking change happened and is not supported.
This is a breaking change, and it should be documented!
A nicer way of handling this would be to add back the public parameter to the function, but just print a warning line to let the developer know it's deprecated.
In summary:
Please document breaking changes.
Make them fail gracefully.
Let the developer know about it, don't just break websites in production.
The text was updated successfully, but these errors were encountered:
A recent upgrade of this library broke our site, as the existing public=True is now breaking every url validation.
Couple of problems I'd like to mention:
url(..., public=...)
is now broken, but silently. By silently I mean that the URLs are all failing validation, without any warning lines, etc. to let the developer know that this breaking change happened and is not supported.Here is how it breaks for example:
This is a breaking change, and it should be documented!
A nicer way of handling this would be to add back the public parameter to the function, but just print a warning line to let the developer know it's deprecated.
In summary:
The text was updated successfully, but these errors were encountered: