Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document breaking change regarding url(public=...) #325

Closed
hyperknot opened this issue Feb 19, 2024 · 0 comments · Fixed by #336
Closed

Document breaking change regarding url(public=...) #325

hyperknot opened this issue Feb 19, 2024 · 0 comments · Fixed by #336
Labels
duplicate Issue/PR: Redundant maintenance PR: Alters existing source code

Comments

@hyperknot
Copy link

A recent upgrade of this library broke our site, as the existing public=True is now breaking every url validation.

Couple of problems I'd like to mention:

  1. This is a breaking change. Every code which has url(..., public=...) is now broken, but silently. By silently I mean that the URLs are all failing validation, without any warning lines, etc. to let the developer know that this breaking change happened and is not supported.

Here is how it breaks for example:

ValidationError(func=url, args={'reason': "url() got an unexpected keyword argument 'public'", 'value': 'https://example.com', 'public': True})
  1. This is a breaking change, and it should be documented!

  2. A nicer way of handling this would be to add back the public parameter to the function, but just print a warning line to let the developer know it's deprecated.

In summary:

  1. Please document breaking changes.
  2. Make them fail gracefully.
  3. Let the developer know about it, don't just break websites in production.
@yozachar yozachar added the maintenance PR: Alters existing source code label Feb 19, 2024
@yozachar yozachar added the duplicate Issue/PR: Redundant label Mar 19, 2024
This was referenced Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue/PR: Redundant maintenance PR: Alters existing source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants