Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs uri validation #195

Closed
SlimBeji opened this issue Sep 2, 2021 · 1 comment · Fixed by #353
Closed

ipfs uri validation #195

SlimBeji opened this issue Sep 2, 2021 · 1 comment · Fixed by #353
Labels
duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months

Comments

@SlimBeji
Copy link

SlimBeji commented Sep 2, 2021

Hello,

Thanks for this awesome library.

I just want to report a tiny issue regarding uri validation:

import validators
uri = "ipfs://someRandomProprietaryAACFile"
validators.url(uri)

The above code returns a ValidationFailure despite the fact that the uri is a valid ipfs uri.
Probably validation does not take into account the ipfs protocol.

Is it possible to add it to validators.url?

Thanks

@yozachar yozachar added duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months labels Mar 14, 2023
@yozachar
Copy link
Collaborator

related #40 #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants