Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy-3.10 support #2678

Closed
jakkdl opened this issue Jul 1, 2023 · 6 comments
Closed

pypy-3.10 support #2678

jakkdl opened this issue Jul 1, 2023 · 6 comments

Comments

@jakkdl
Copy link
Member

jakkdl commented Jul 1, 2023

https://github.com/python-trio/trio/actions/runs/5430814069/jobs/9876779099?pr=2668

build currently fails with

../../../_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/trio/_tests/test_ssl.py:16: in <module>
    from OpenSSL import SSL
../../../_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/OpenSSL/__init__.py:8: in <module>
    from OpenSSL import SSL, crypto
../../../_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/OpenSSL/SSL.py:19: in <module>
    from OpenSSL.crypto import (
../../../_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/OpenSSL/crypto.py:21: in <module>
    from cryptography import utils, x509
../../../_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/cryptography/x509/__init__.py:6: in <module>
    from cryptography.x509 import certificate_transparency
../../../_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/cryptography/x509/certificate_transparency.py:10: in <module>
    from cryptography.hazmat.bindings._rust import x509 as rust_x509
E   ImportError: /home/runner/work/_temp/27281372-7da6-47ad-9c04-eadab99b87dc/pypy-c-jit-107527-ae3a931895a8-linux64/lib/pypy3.10/site-packages/cryptography/hazmat/bindings/_rust.pypy310-pp73-x86_64-linux-gnu.so: undefined symbol: PySlice_AdjustIndices

on test_dtls, test_highlevel_ssl_helpers and test_ssl.

@A5rocks
Copy link
Contributor

A5rocks commented Jul 2, 2023

We probably just have to bump our cryptography requirement.

@jakkdl
Copy link
Member Author

jakkdl commented Jul 3, 2023

yep, bumping to 41 worked - except now I'm hitting problems building ssl on pypy3.10 windows.
https://github.com/python-trio/trio/actions/runs/5444000246/jobs/9901247485#step:4:1050

@jakkdl
Copy link
Member Author

jakkdl commented Jul 3, 2023

I'm dropping windows-pypy3.10 in #2668 for now, anybody else feel free to go at that in another PR.

@Fuyukai
Copy link
Member

Fuyukai commented Apr 12, 2024

This has, in fact, already been done?

@Fuyukai Fuyukai closed this as completed Apr 12, 2024
@jakkdl
Copy link
Member Author

jakkdl commented Apr 13, 2024

Only for linux, looking at CI we might not be testing pypy at all on windows atm?

@A5rocks
Copy link
Contributor

A5rocks commented Apr 13, 2024

Seems fine to subsume this into the general CI megaissue if it's a basic issue/just a matter of updating matrix and seeing what breaks (if we don't know if this is up to date). Looking at that CI issue, I'm pretty sure this was about macOS pypy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants