-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry to Heroku's Python buildpack #971
Comments
I've done a pull request to Heroku's Python buildpack with testing and all. You could find my fork here aswell. I've submitted this pull request 20 days ago with no feedback so far. It need some obvious adjustments. I really do not know what's happening with their CI (probably needs some special authentication, or the hatchet API keys expired, since the main admin is having issues on submitting their own pull requests). However, I used docker and There is always room for improvement and I hope you succeed where I failed, Cheers PS: Your pull request and issues should be directed to that package. I think they will close it here. |
@AndreGuerra123 Have you suceeded in using your buildpack on a heroku dyno? |
@golyalpha - this looks more like a Heroku issue than a Poetry one. Would you mind closing this issue and tracking there? |
@AndreGuerra123 You apparently have a typo in the pull request's code. @cjw296 Alright, will do, since it seems integration is underway. |
FYI we have written our own buildpack to plug it on top of the official Python buildpack, because no-one knows if and when Heroku will officially support Poetry: https://github.com/moneymeets/python-poetry-buildpack |
Yeah, I just ended up using the container runtime and Dockerfile+heroku.yml instead of Heroku's buildpacks. Ended up making our migration away from Heroku about 10x more painless in the long run. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Feature Request
As things are currently, I'd really love to use poetry for all my projects, unfortunately, I can't.
I have about 5 Python projects, of which I am the sole author, running on Heroku, as of right now, most of them are using Pipenv or bare pip for dependencies, the reason being simple: The official Python buildpack doesn't support poetry, and I couldn't find one that does.
I know that this is more of an issue with the Python buildpack for Heroku, than with Poetry itself, but if we don't take steps towards getting it supported, who else should? That is why am I posting an issue here.
I have a fork of the buildpack, where I'm trying to add that support here, but I lack the means necessary to test it, so I encourage you to test it, and help me out with that in general.
The text was updated successfully, but these errors were encountered: