Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for tests/helpers.py #9161

Open
Tracked by #3155
abn opened this issue Mar 14, 2024 · 7 comments
Open
Tracked by #3155

Add test coverage for tests/helpers.py #9161

abn opened this issue Mar 14, 2024 · 7 comments

Comments

@abn
Copy link
Member

abn commented Mar 14, 2024

As requested by @Secrus in #9149 (comment).

@dimbleby
Copy link
Contributor

I don't understand. If there is code in tests/helpers.py that is not executed, just remove it already?

@DarkTechPirate

This comment was marked as duplicate.

@abn
Copy link
Member Author

abn commented Mar 17, 2024

@dimbleby I think @Secrus is asking for test helpers to have functional test coverage. But yes, if we are not using a helper we should remove it. Although, I do not think that is the case right now.

@dimbleby
Copy link
Contributor

I dont buy it: who writes tests for their tests? what then, shall we write tests for the tests for the tests too?

test code automatically gets coverage by being executed in the test suite, else delete it

@abn
Copy link
Member Author

abn commented Mar 18, 2024

I'll let @Secrus decide what they want to do with this one as I just created the issue based on his request. 😉

@dimbleby
Copy link
Contributor

@Julynx you have completely misunderstood what is being discussed here

@Julynx
Copy link

Julynx commented Apr 10, 2024

@Julynx you have completely misunderstood what is being discussed here

Fair, I apologize for the misunderstading and I'm deleting my previous reply. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants