Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc workflow should declare required permissions #8819

Closed
2 tasks done
jsoref opened this issue Dec 24, 2023 · 1 comment · Fixed by #8820
Closed
2 tasks done

Doc workflow should declare required permissions #8819

jsoref opened this issue Dec 24, 2023 · 1 comment · Fixed by #8820
Labels
kind/feature Feature requests/implementations

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 24, 2023

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

GitHub workflows that do interesting things should define the permissions they require: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview

In the case of the doc workflow, it needs contents: read to checkout, and amondnet/vercel-action@v25 github-comment needs pull-requests: write

@jsoref jsoref added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Dec 24, 2023
@jsoref jsoref mentioned this issue Dec 24, 2023
2 tasks
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@abn abn removed the status/triage This issue needs to be triaged label Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants