Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required dependency missing from lockfile #6434

Closed
2 of 3 tasks
levrik opened this issue Sep 7, 2022 · 5 comments · Fixed by #6730
Closed
2 of 3 tasks

Required dependency missing from lockfile #6434

levrik opened this issue Sep 7, 2022 · 5 comments · Fixed by #6730
Labels
kind/enhancement Not a bug or feature, but improves usability or performance

Comments

@levrik
Copy link

levrik commented Sep 7, 2022

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

Adding the package ariadne to an empty project via poetry add ariadne results in a lockfile being generated with the starlette dependency missing from it.
We discovered it by upgrading an existing project to Poetry 1.2.0 and re-installing ariadne. It resulted in the following diff:

image

The package clearly defines starlette as an required dependency, as can be seen here: https://github.com/mirumee/ariadne/blob/0.15.1/setup.py#L36

The METADATA file in the downloaded Wheel also contains this line: Requires-Dist: starlette (>0.17<0.20)

@levrik levrik added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Sep 7, 2022
@levrik levrik changed the title Required dependency remove from lockfile Required dependency missing from lockfile Sep 7, 2022
@levrik
Copy link
Author

levrik commented Sep 7, 2022

I just realized that the version range defined by ariadne is just wrong, missing a comma between >0.17 and <0.20 ?

@levrik
Copy link
Author

levrik commented Sep 7, 2022

Okay. Seems to have been fixed already on their side: mirumee/ariadne#877

So no bug on Poetry's side. Still it would be great if Poetry could maybe output a warning during installation instead of silently ignoring the dependency?

@dimbleby
Copy link
Contributor

dimbleby commented Sep 7, 2022

There's a debug log for this, I expect that an MR making this a warning would be welcome

logger.debug(
f"Invalid constraint ({req}) found in"
f" {package.name}-{package.version} dependencies, skipping",
)

@levrik
Copy link
Author

levrik commented Sep 7, 2022

@dimbleby Thanks for pointing this out. I'll try to create a PR when I have time.

@mkniewallner mkniewallner added kind/enhancement Not a bug or feature, but improves usability or performance and removed status/triage This issue needs to be triaged kind/bug Something isn't working as expected labels Sep 11, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants