-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required dependency missing from lockfile #6434
Comments
I just realized that the version range defined by |
Okay. Seems to have been fixed already on their side: mirumee/ariadne#877 So no bug on Poetry's side. Still it would be great if Poetry could maybe output a warning during installation instead of silently ignoring the dependency? |
There's a debug log for this, I expect that an MR making this a warning would be welcome poetry/src/poetry/inspection/info.py Lines 208 to 211 in 28d0175
|
@dimbleby Thanks for pointing this out. I'll try to create a PR when I have time. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).Issue
Adding the package
ariadne
to an empty project viapoetry add ariadne
results in a lockfile being generated with thestarlette
dependency missing from it.We discovered it by upgrading an existing project to Poetry 1.2.0 and re-installing
ariadne
. It resulted in the following diff:The package clearly defines
starlette
as an required dependency, as can be seen here: https://github.com/mirumee/ariadne/blob/0.15.1/setup.py#L36The
METADATA
file in the downloaded Wheel also contains this line:Requires-Dist: starlette (>0.17<0.20)
The text was updated successfully, but these errors were encountered: