Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Parse string results #9

Open
MrNeocore opened this issue May 25, 2021 · 2 comments
Open

Enhancement: Parse string results #9

MrNeocore opened this issue May 25, 2021 · 2 comments

Comments

@MrNeocore
Copy link
Contributor

MrNeocore commented May 25, 2021

Proposition: Enhancement

In some cases, the Pinot Broker REST API returns string values [e.g. "Infinity"] as results (as part of rows) when the value cannot be represented as a JSON "number".

To improve predictability from the Python client, should we parse this output string(s) as a Python native numeric type ?

Simply parsing with float should cover many cases and allow for more "natural" handling of Pinot's results from Python.

Should we apply a similar approach to parsing for other types ? (which ones ?)

@xiangfu0
Copy link
Contributor

Agreed. We should handle this case base on the python type and value.

@MrNeocore
Copy link
Contributor Author

@xiangfu0 Alright, I'll have a deeper look at the code and ready a PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants