Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of type annotations #1298

Open
salotz opened this issue Sep 9, 2024 · 2 comments
Open

Status of type annotations #1298

salotz opened this issue Sep 9, 2024 · 2 comments

Comments

@salotz
Copy link

salotz commented Sep 9, 2024

I got a bit confused about the state of type annotations for the project via the other issues. It seems that the current idea is to finish type checking this project?

If so having an issue to track the progress of that would help me. Currently I will just have to turn off typechecking for this library, but if it is close would be nice to know when that lands.

@sirosen
Copy link
Member

sirosen commented Jan 1, 2025

typeshed has a stubs packages (types-jsonschema) which you can use for right now. They may be slightly amiss, since typeshed is a "best effort" stub repository for many packages, but feel free to report issues there and @-mention me if you need a hand fixing those.

I'm going to try to put some effort this year into getting enough annotations in place for jsonschema that we can publish types from here without it being a significant regression for type checkers.

@dangotbanned
Copy link

@sirosen I'm loosely following-up after (#1019 (comment)) and a subsequent downstream "fix" in (vega/altair#3475)

One comment in particular has a pretty high level overview of an issue in the stubs (https://github.com/python/typeshed/tree/9f28171658b9ca6c32a7cb93fbb99fc92b17858b/stubs/jsonschema)

I don't know what the right answer is, but I'd really appreciate any efforts towards hiding/limiting the exposure of Unset:

class Unset:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants