Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "custom markers" example in reference to use new marker API #3394

Closed
nicoddemus opened this issue Apr 12, 2018 · 3 comments
Closed

Update "custom markers" example in reference to use new marker API #3394

nicoddemus opened this issue Apr 12, 2018 · 3 comments
Assignees
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification

Comments

@nicoddemus
Copy link
Member

Just noticed that the section custom markers shows an example using Node.get_marker. We should update the example in the features branch to showcase the new markers API, possibly showing a case where markers are applied multiple times (for example in a class and a test function at the same time).

cc @RonnyPfannschmidt

@nicoddemus nicoddemus added type: docs documentation improvement, missing or needing clarification good first issue easy issue that is friendly to new contributor labels Apr 12, 2018
@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #2153 (Bad user experience using custom markers on params), #631 (markers leaking), #2999 (Update public api for getting finalizers), #277 (Markers as functions), and #379 (Can't not apply multiple markers to individual test when using parametrize).

@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Apr 12, 2018
@Lekensteyn
Copy link

Hasn't this issue been resolved already via https://docs.pytest.org/en/latest/mark.html?
The linked section in the reference also mentions the new Node.iter_markers API which links to said page.

@nicoddemus
Copy link
Member Author

Thanks @Lekensteyn, this issue was already fixed then. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

No branches or pull requests

4 participants