From 90ee38a2b2505b95003235a8c0617079c1fdd098 Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:11:09 +0100 Subject: [PATCH 01/19] fix: no-detach was incomplete --- ani-cli | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ani-cli b/ani-cli index f262ab458..66ac991b3 100755 --- a/ani-cli +++ b/ani-cli @@ -1,6 +1,6 @@ #!/bin/sh -version_number="4.7.6" +version_number="4.7.7" # UI @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" == 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 9b04f129b156300e64eb2fc14199767739f61d32 Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:14:00 +0100 Subject: [PATCH 02/19] try to appease shellcheck --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 66ac991b3..f895aebcd 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" == 0 ] && echo ">/dev/null 2>&1 &") ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From a1b3bd013a71812b7ad3398369db68fc16222526 Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:16:28 +0100 Subject: [PATCH 03/19] odd... --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index f895aebcd..5c9d30bc5 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo '>/dev/null 2>&1 &') ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 2a84d571df42cf89d639cba7b7ed95b7073fbb8e Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:19:15 +0100 Subject: [PATCH 04/19] like this maybe? --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 5c9d30bc5..829ec4765 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo '>/dev/null 2>&1 &') ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 $([ "$no_detach" = 0 ] && echo "&") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 955b8cf04c5bf272e29bd7005dde4c0e435b27a2 Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:21:01 +0100 Subject: [PATCH 05/19] bob'n'weave --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 829ec4765..3e261f2df 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 $([ "$no_detach" = 0 ] && echo "&") ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 "$([ "$no_detach" = 0 ] && echo "&" || true)" ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From b11a20027328e6772df7bd8dec5e88b4c9bb2937 Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:24:06 +0100 Subject: [PATCH 06/19] =?UTF-8?q?jkl=C3=B6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 3e261f2df..89fa87886 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 "$([ "$no_detach" = 0 ] && echo "&" || true)" ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 "$([ "$no_detach" = 0 ] && echo "&")" ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 210d11caebc51ff0a2157e7db0ae64ecc8a6704c Mon Sep 17 00:00:00 2001 From: port19 Date: Sun, 4 Feb 2024 21:25:51 +0100 Subject: [PATCH 07/19] back to intended state, possibly raise issue @shellcheck --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 89fa87886..829ec4765 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 "$([ "$no_detach" = 0 ] && echo "&")" ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 $([ "$no_detach" = 0 ] && echo "&") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 696d8e26d36d324f39968d85f1bfb40d8815e79a Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 17:28:13 +0100 Subject: [PATCH 08/19] only redirect to /dev/null when not no_detach --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 829ec4765..f895aebcd 100755 --- a/ani-cli +++ b/ani-cli @@ -240,7 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 $([ "$no_detach" = 0 ] && echo "&") ;; + mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From ff924ab38b79119d4b7a37c0f373d324fa6bc24c Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 17:52:14 +0100 Subject: [PATCH 09/19] do a shellcheck disable on the no_detach feature-line --- ani-cli | 1 + 1 file changed, 1 insertion(+) diff --git a/ani-cli b/ani-cli index 6e029d9e7..5d71d6279 100755 --- a/ani-cli +++ b/ani-cli @@ -240,6 +240,7 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; + # shellcheck: disable=S2086,2312 mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; From 047143448b0b2b62e163b26bccd73a5b8edad418 Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 17:54:17 +0100 Subject: [PATCH 10/19] multi-line mpv case due to primitive shellcheck parsing --- ani-cli | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ani-cli b/ani-cli index 5d71d6279..d589d025a 100755 --- a/ani-cli +++ b/ani-cli @@ -240,9 +240,11 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - # shellcheck: disable=S2086,2312 - mpv*) $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; - android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; + mpv*) + # shellcheck: disable=S2086,2312 + $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; + android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & + ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; flatpak_mpv) flatpak run io.mpv.Mpv --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 6b3a9374a28bb8a1c81e35c48b3ff670dd951eb2 Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 18:05:30 +0100 Subject: [PATCH 11/19] misspelled `shellcheck disable` --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index d589d025a..b4519a9f0 100755 --- a/ani-cli +++ b/ani-cli @@ -241,7 +241,7 @@ play_episode() { printf "%s\n" "$episode" ;; mpv*) - # shellcheck: disable=S2086,2312 + # shellcheck disable=S2086,2312 $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; From f0280fb4cd4478cdb06474bbf15add1d49a6df7e Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 18:09:51 +0100 Subject: [PATCH 12/19] add temp line to trigger github ci :angry: --- ani-cli | 1 + 1 file changed, 1 insertion(+) diff --git a/ani-cli b/ani-cli index b4519a9f0..ddf19bb4a 100755 --- a/ani-cli +++ b/ani-cli @@ -477,3 +477,4 @@ done # along with this program. If not, see . # # Project repository: https://github.com/pystardust/ani-cli +this line will be removed again... github actions didn't trigger on previous commit for some reason From c1f83b56a0973d31b70c350acc6aafde8f465eae Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 18:11:34 +0100 Subject: [PATCH 13/19] shellcheck is killing me --- ani-cli | 1 - 1 file changed, 1 deletion(-) diff --git a/ani-cli b/ani-cli index ddf19bb4a..b4519a9f0 100755 --- a/ani-cli +++ b/ani-cli @@ -477,4 +477,3 @@ done # along with this program. If not, see . # # Project repository: https://github.com/pystardust/ani-cli -this line will be removed again... github actions didn't trigger on previous commit for some reason From fd57b9c5f51624a768394521e006e7cb0d348639 Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 18:12:06 +0100 Subject: [PATCH 14/19] now? --- ani-cli | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ani-cli b/ani-cli index b4519a9f0..2594f0b5b 100755 --- a/ani-cli +++ b/ani-cli @@ -242,9 +242,9 @@ play_episode() { ;; mpv*) # shellcheck disable=S2086,2312 - $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; - android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & + $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; + android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; iina) nohup "$player_function" --no-stdin --keep-running --mpv-force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; flatpak_mpv) flatpak run io.mpv.Mpv --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & ;; From 3c9888e31f1a748c1b5d7af3d5925aaef81d1ae3 Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 8 Feb 2024 18:27:48 +0100 Subject: [PATCH 15/19] fix trailing spaces --- ani-cli | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ani-cli b/ani-cli index 2594f0b5b..8ec00c6d1 100755 --- a/ani-cli +++ b/ani-cli @@ -240,9 +240,9 @@ play_episode() { [ -z "$ANI_CLI_NON_INTERACTIVE" ] && printf "All links:\n%s\nSelected link:\n" "$links" printf "%s\n" "$episode" ;; - mpv*) + mpv*) # shellcheck disable=S2086,2312 - $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") + $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; From 4917eb2374d196fec58ed4e086cca921999d9ad9 Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 21 Mar 2024 09:31:51 +0100 Subject: [PATCH 16/19] add trailing whitespace to trigger ci run --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 8ec00c6d1..736b9b894 100755 --- a/ani-cli +++ b/ani-cli @@ -242,7 +242,7 @@ play_episode() { ;; mpv*) # shellcheck disable=S2086,2312 - $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") + $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; From cfb1e58dcb729dd66881264cad36f8f65a851d8f Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 21 Mar 2024 09:36:06 +0100 Subject: [PATCH 17/19] another one --- ani-cli | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ani-cli b/ani-cli index 736b9b894..d524701df 100755 --- a/ani-cli +++ b/ani-cli @@ -1,6 +1,6 @@ #!/bin/sh -version_number="4.8.1" +version_number="4.8.3" # UI @@ -241,8 +241,7 @@ play_episode() { printf "%s\n" "$episode" ;; mpv*) - # shellcheck disable=S2086,2312 - $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") + $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; From 1e877d29f0274040fe30897088e22979c3c38757 Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 21 Mar 2024 09:42:12 +0100 Subject: [PATCH 18/19] aight, I give up, if-else it is --- ani-cli | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index 421a8d2cd..ee235baf4 100755 --- a/ani-cli +++ b/ani-cli @@ -248,7 +248,11 @@ play_episode() { printf "%s\n" "$episode" ;; mpv*) - $([ "$no_detach" = 0 ] && echo "nohup") "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" $([ "$no_detach" = 0 ] && echo ">/dev/null 2>&1 &") + if [ "$no_detach" = 0]; then + nohup "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & + else + "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" + fi ;; android_mpv) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n is.xyz.mpv/.MPVActivity >/dev/null 2>&1 & ;; android_vlc) nohup am start --user 0 -a android.intent.action.VIEW -d "$episode" -n org.videolan.vlc/org.videolan.vlc.gui.video.VideoPlayerActivity -e "title" "${allanime_title}Episode ${ep_no}" >/dev/null 2>&1 & ;; From 297db84df49364d38ad97d1fcf9c38aee41a186f Mon Sep 17 00:00:00 2001 From: port19 Date: Thu, 21 Mar 2024 09:43:33 +0100 Subject: [PATCH 19/19] silly me, forgetting space before ] --- ani-cli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ani-cli b/ani-cli index ee235baf4..fbbed0d22 100755 --- a/ani-cli +++ b/ani-cli @@ -248,7 +248,7 @@ play_episode() { printf "%s\n" "$episode" ;; mpv*) - if [ "$no_detach" = 0]; then + if [ "$no_detach" = 0 ]; then nohup "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode" >/dev/null 2>&1 & else "$player_function" $skip_flag --force-media-title="${allanime_title}Episode ${ep_no}" "$episode"