-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caveats to macaroons for expiration (time) and version #6255
Comments
This is a fine idea to add onto future work for #994 -- thank you! I believe it's out of scope for our current funding for security improvements to PyPI, sorry to say. |
Another potentially useful caveat would be IP address/range, for future consideration. |
@rcipkins is going to take a stab at this! |
@rcipkins -- how is this going? |
@brainwane I am almost finished, I just need to fix a couple things and add tests! |
@rcipkins - Great to hear! It's a good idea to push your branch to your GitHub fork and start a "work in progress" ("WIP") pull request. That way:
To do this, push your branch to your fork, and create a pull request where the start of the PR title is "(WIP)". Looking forward to seeing it! |
Done! Thank you so much! |
NB: This is addressed by #11122. (We'll need separate UI work to make that caveat useable with user-minted macaroons, but that PR will add all of the backend logic needed.) |
What's the problem this feature will solve?
This will allow further attenuating the permissions granted by an API key
Describe the solution you'd like
Addition of two addition types of caveat, project version (for uploads) and time (expiry).
The text was updated successfully, but these errors were encountered: